ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations

MIT License

183 stars 82 forks source link

Nit: primitives is misspelled in py_ecc.bls module #104

Closed prestwich closed 2 days ago

prestwich commented 3 years ago

What is wrong?

Really small nit. primitives is incorrectly spelled primatives in py_ecc.bls.g2_primatives

hwwhww commented 3 years ago

Nice catch! 😮

Hmm, although it's a typo, we will have a backward-compatible issue if we just rename the file. Probably need to rename + add an alias primatives for compatibility. 😅

prestwich commented 3 years ago

I can put out a branch later today👌

prestwich commented 3 years ago

ugh I hit "close with comment" instead of just comment 🤣

prestwich commented 3 years ago

see #105

pacrob commented 2 days ago

closed by #105