Unification of interfaces across secp256k1 and bls - Githubissues

ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations

MIT License

183 stars 82 forks source link

Unification of interfaces across secp256k1 and bls #119

Open pipermerriam opened 3 years ago

pipermerriam commented 3 years ago

What is wrong?

It would be nice if py_ecc.secpk256k1, py_ecc.bls12_381 and py_ecc.bn128 all had roughly the same API.

How can it be fixed

A combination of exposing a few un-exposed APIs from secpk256k1 and renaming things.

expose add and multiply from py_ecc.secp256k1.secp256k1 from py_ecc.secp256k1
I think py_ecc.secp256k1.secp256k1.inv needs to be renamed/aliased to neg to line up with the bls/bn APIs.
some other things like field_modulus and curve_order might need to have their equivalent values exposed from secp256k1