search

ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations
MIT License
191 stars 82 forks source link

[WIP] Added type hinting #18

Closed 6ug closed 1 month ago

6ug commented 5 years ago

Fixes https://github.com/ethereum/py_ecc/issues/11 Totally fine tuned manually! automated tools not handling dynamic execution.

6ug commented 5 years ago

PR https://github.com/ethereum/py_ecc/pull/19 should fix ^^ above CI failures.

pipermerriam commented 5 years ago

Looks like ci failures are some small linting errors, and failing due to python 2.7 not supporting type hints.

@carver I'm inclined to drop python 2 support. Can you confirm?

carver commented 5 years ago

I'm inclined to drop python 2 support. Can you confirm?

Yeah, the next release can be v2 :+1:

pipermerriam commented 5 years ago

@6ug looks like this needs to be rebased against master

6ug commented 5 years ago

@pipermerriam our last typing: Module not found issue was due to - python3.4 does not have inbuilt support for PEP-484 type hinting, we need to externally add typing in this case, https://github.com/ethereum/py_ecc/pull/18/commits/d86ca0e2afe7a69cc4b6b967bc81ba0b03a2db90 will fix that.

carver commented 5 years ago

We should drop py3.4 as well, while we're dropping old python versions. Maybe even py3.5 too.

pipermerriam commented 5 years ago

ping @6ug are you still working on this?

pacrob commented 1 month ago

Closed by #143