search

ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations
MIT License
191 stars 82 forks source link

Enable Type Hinting for optimized_bn128 module #29

Closed Bhargavasomu closed 5 years ago

Bhargavasomu commented 5 years ago

What was wrong?

As part of #11 , the module optimized_bn128 needs to be type hinted

How was it fixed?

Manually type hinting and running mypy.

Cute Animal Picture

put a cute animal picture link inside the parentheses

Bhargavasomu commented 5 years ago

@pipermerriam this is just for checking the correctness, and apparently there is a flake error in bls module as per the linting error. Should I be bothered about that?

Also I will be making the necessary changes as per #28

Bhargavasomu commented 5 years ago

@pipermerriam could you please take a look now?

pipermerriam commented 5 years ago

@Bhargavasomu I'm going to wait for #28 to be reviewed and merged and then this can be rebased (after which I'll take a look).

Bhargavasomu commented 5 years ago

@pipermerriam could you take a look at this now and we can close the issue and bounty #11.