ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations
MIT License
191 stars 82 forks source link

Move to SHA256 #68

Closed zilm13 closed 5 years ago

zilm13 commented 5 years ago

What is wrong?

ETH2.0 is using SHA256 instead of Keccak256 since v0.6.0 following this PR https://github.com/ethereum/eth2.0-specs/pull/779
Py-ecc is still using Keccak256: https://github.com/ethereum/py_ecc/blob/master/py_ecc/bls/hash.py
Py-ecc is used in BLS test generators etc.

How can it be fixed

By changing hashing algo to SHA256 + new version release, so it could be used as dependency.