search

ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations
MIT License
191 stars 82 forks source link

Use SHA-256 instead of Keccak256 #70

Closed ralexstokes closed 5 years ago

ralexstokes commented 5 years ago

What was wrong?

Fixes #68.

Updates the hash function so we can generate correct BLS tests in the eth2.0 specs/tests repo.

How was it fixed?

Use the stdlib's SHA-256 instead of the Keccak256 import.

Cute Animal Picture

put a cute animal picture link inside the parentheses

carver commented 5 years ago

@ralexstokes Do you prefer squash merges or do you like to rebase/squash and then merge commit (I'm a fan of the latter)?

djrtwo commented 5 years ago

Whatever you're a fan of @carver :)

We're looking to merge this and get a minor version release out today. I can handle this unless you have a preferred workflow

carver commented 5 years ago

We're looking to merge this and get a minor version release out today. I can handle this unless you have a preferred workflow

Nope, no specific thing I need to be involved for. :+1: Please update the changelog.