search

ethereum / py_ecc

Python implementation of ECC pairing and bn_128 and bls12_381 curve operations
MIT License
191 stars 82 forks source link

Add tests for behaviors #75

Closed ChihChengLiang closed 4 years ago

ChihChengLiang commented 5 years ago

What was wrong?

Fix #74, add tests to confirm the behavior of the verifying empty public key and signature.

Fix #65 by the way, add tests to confirm the behavior of aggregating empty lists of public key and signature.

Cute Animal Picture

put a cute animal picture link inside the parentheses

carver commented 5 years ago

I'm on board with having verify() return False for the empty public key, if you'd like to get that folded in now. :+1:

hwwhww commented 4 years ago

closing it now since empty aggregate is invalid in the new BLS standard.