ethereum / pyethapp

MIT License
1.28k stars 604 forks source link

pyethapp does not respect the data_dir setting in config.yaml #282

Open wangyifan opened 6 years ago

wangyifan commented 6 years ago

Checklist

System/environment

Expected behaviour

  1. Set data_dir in config.yaml
  2. Expect pyethapp to respect the data_dir value set in config.yaml

Observed behaviour

  1. Set data_dir in config.yaml
  2. Run "pyethapp config" and it's still using the old data_dir value

Steps to reproduce

As explained in 'Expected behaviour' and 'Observed behaviour'

Currently it is only possible to use an alt data_dir by setting it in cli. IMHO, it would be better to have the app respect the data_dir value set in the config.yaml and make it possible to override it in cli.

I can prepare a fix for the above behavior if you guys are ok with it.