Write Log class for twig event testing

ethereum / pytest-ethereum

MIT License

19 stars 12 forks source link

Write Log class for twig event testing #12

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

Log class created to help with logged events testing in twig pytest_ethereum.tx_fail() created to help with exception testing in twig

based off discussion here

Cute Animal Picture

njgheorghita commented 5 years ago

@fubuloubu Thanks! improved the test comments and wrote up some actual docs for the class. Agree that it's not incredibly concise, but what you said about it could be overridden, plus it's not a huge priority for me right now

fubuloubu commented 5 years ago

I'm being more and more convinced that contract syntax classes are a better solution. Let the user decide that the like a set of shortcuts, and let them do it in any tool (not just testing)

Perhaps twig could implement this class?