Convert to strict-manifest interface, remove compilation utils

ethereum / pytest-ethereum

MIT License

19 stars 12 forks source link

Convert to strict-manifest interface, remove compilation utils #30

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

pte had multiple deployers, that would either load from manifest, or compile assets (depending on the contract's language). In order to simplify pte's api, it now only needs a manifest (EthPM spec-compliant) in order to create a deployer (regardless of the contract language). It now only exposes a single deployer fixture rather than vy_deployer & sol_deployer, and has no compilation abilities.

Cute Animal Picture

njgheorghita commented 5 years ago

@pipermerriam I'm having trouble figuring out what's causing circleci to fail - any thoughts?

pipermerriam commented 5 years ago

pip._vendor.packaging.requirements.InvalidRequirement: Parse error at "'(===3.2.'": Expected stringEnd

That line makes me think that one of the requirements has an invalid version string. I'd first try to reproduce locally in a new venv or re-run the circle-ci run with SSH enabled and SSH into the box there. Probably will take a little digging to figure out which requirement it is.

pipermerriam commented 5 years ago

Looks like it was this: https://github.com/ethereum/py_ecc/pull/37

njgheorghita commented 5 years ago

@pipermerriam ping for review - removed all compilation and updated pte's api to be manifest-based