Closed stranger80 closed 7 months ago
thanks @stranger80! @LianaHus could you have a look at the plugin UX.
thanks @stranger80! @LianaHus could you have a look at the plugin UX.
Hello! May I ask for feedback on this? Can we aim for the plugin launch today/tomorrow (6th-7th Dec)?
sorry for the dumb question but I need a bit of context. zsync uses a specific version of the solidity compiler? can you point me to it?
Hi @yann300 !
This plugin is using a zksolc compiler in the background (https://github.com/matter-labs/zksolc-bin) as per the description in https://era.zksync.io/docs/tools/compiler-toolchain/solidity.html . In fact, we use the HardHat wrapper for zksolc: https://era.zksync.io/docs/tools/hardhat/hardhat-zksync-solc.html
I hope this makes things clearer.
Overall looks good. Could you have a look please @LianaHus ?
But the plugin doesn't seem to respond on theme changed
see
Also the dropdown may need to use bootstrap classes. Are you using bootstrap classes?
I take the point on the themes, we are working to get this rectified, but we also very keen on publishing this as an early alpha for the users. This is also on the back of our other plugin - Starknet - which has caught substantial traction and generated quite some traffic. Do you think we can still publish the zkSync alpha, while we continue work on styling (which is expected to be refurbished significantly anyway).
ok let me check that with the others. Also could you link to some doc or spec that would list the diff between zksolc and the normal one?
That's fine, if you need it now we are going to merge it, but we really need it to be working with all the themes (same for the starknet plugin). Would you be able to make those changes (for both plugins) until like wednesday 13th. We can help if you need anything (see https://remix-plugins-directory.readthedocs.io/en/latest/getting_started.html#bootstrap-css or feel free to contact us in tg or discord). Pass that date we'll need to review them again with some team members to see if it's better to temporarily remove them or not. Hope you understand, again don't hesitate to contact us, this shouldn't be so hard, it's just about using bootstrap classes. Thanks!
Thanks for merging!
The plugin now also supports themes:
Will be implementing the same changes in the Starknet plugin shortly.
We're reworking the plugins to look as follows:
We are adding a new Remix plugin to assist in development, compilation and deployment of Solidity smart contracts for zkSync Era ecosystem: