New Uniswap v4 templates

ethereum / remix-project

Remix is a browser-based compiler and IDE that enables users to build Ethereum contracts with Solidity language and to debug transactions.

https://remix-ide.readthedocs.io

MIT License

2.4k stars 913 forks source link

New Uniswap v4 templates #4409

Open ryestew opened 8 months ago

ryestew commented 8 months ago

[ ] Breakthrough Labs Uniswap V4 hooks don't open a file in the FE - so normal behavior. But the scripts/FAIR_TRADE/FairTrade.s.sol file has compilation errors. It can't find anything inside the lib folder because all the lib folder's subfolders are empty.
[ ] MultiSigSwapHook gets cloned and opens a file in the FE - unique in all our templates.
[ ] V4 Perifery template - contracts/hooks/limitOrder.sol doesn't compile becasue its missing the folders inside of lib/v4-core

yann300 commented 8 months ago

for the first and third, you should click on update submodule to clone the submodule. any idea how to make it more obvious? For the second this is a behavior of the cookbook api we are calling...

yann300 commented 6 months ago

Breakthrough Labs Uniswap V4 hooks don't open a file in the FE - so normal behavior. But the scripts/FAIR_TRADE/FairTrade.s.sol file has compilation errors. It can't find anything inside the lib folder because all the lib folder's subfolders are empty.

V4 Perifery template - contracts/hooks/limitOrder.sol doesn't compile becasue its missing the folders inside of lib/v4-core

that's because you need to update submodule. That probably need to be improved.

yann300 commented 6 months ago

MultiSigSwapHook gets cloned and opens a file in the FE - unique in all our templates.

Setting up the template is deferred to the cookbook plugin, that why the flow is a bit different, Is this something you would like to dig further?