Inconsistency in expect.storage between state and blockchain tests

ethereum / retesteth

testeth via RPC. Test run, generation by t8ntool protocol

http://retesteth.ethdevops.io/

GNU General Public License v3.0

113 stars 75 forks source link

Inconsistency in expect.storage between state and blockchain tests #120

Closed qbzzt closed 3 years ago

qbzzt commented 3 years ago

When you have

expect:
   0xccc..cccc:
      storage:
         0x00: 0x01

And there is a value in a different storage cell, the test types behave differently:

In a state test that's an error and the test fails
In a blockchain test that is fine and the test is successful

I think it would be better if the state test behavior was followed by both test types.

winsvega commented 3 years ago

this I get is the same

Error: Check State: Remote account '0x095e7baea6a6c7c4c2dfeb977efac326af552d87' test expected storage key: '0x00' to be set to: '0x01', but remote key '0x00' does not exist! (bcValidBl

can you bring a better example how to reproduce the begavior?

qbzzt commented 3 years ago

It's not when the expected key does not exist, but when an unexpected key does. I'll write test cases in a bit.

winsvega commented 3 years ago

Error: Check State: Remote account '0x095e7baea6a6c7c4c2dfeb977efac326af552d87'  has more storage records than expected!
 [0x03] = 0x05 (stExample/add11, fork: Berlin, TrInfo: d: 0, g: 0, v: 0)

same still

qbzzt commented 3 years ago

And now I can't replicate it either. Sorry, my bad.