search

ethereum / retesteth

testeth via RPC. Test run, generation by t8ntool protocol
http://retesteth.ethdevops.io/
GNU General Public License v3.0
113 stars 75 forks source link

Make comparisons non-case sensitive #93

Closed matkt closed 4 years ago

matkt commented 4 years ago

The comparison of fields is case-sensitive. We may have errors as below (which are false positives). It would be great to no longer be case-sensitive

Error: Error checking remote transaction, remote tr gas is different to test tr gasLimit (0xfffff2 != 0xFFFFF2)

winsvega commented 4 years ago

actually I am looking at this right now and I think what we need are types. initially retesteth was supposed to work only with json text and know nothing about ethereum types like h256 h32 address bytes but with state transition tool support retesteth become like a light client. being able to handle blockchain logic. so I think to change strings into types

matkt commented 4 years ago

actually I am looking at this right now and I think what we need are types. initially retesteth was supposed to work only with json text and know nothing about ethereum types like h256 h32 address bytes but with state transition tool support retesteth become like a light client. being able to handle blockchain logic. so I think to change strings into types

makes sens. We will wait for this update

winsvega commented 4 years ago

(0xfffff2 != 0xFFFFF2) where do you get this error? can you provide an example? I see that test sources can have 0xFFaa values just fine

try on t8ntool branch

matkt commented 4 years ago

Yes for example this test https://github.com/ethereum/tests/blob/52d5247fe41f489c274e4254b151520bc3f20cc7/src/GeneralStateTestsFiller/stMemExpandingEIP150Calls/CallAndCallcodeConsumeMoreGasThenTransactionHasWithMemExpandingCallsFiller.json#L65 if you replace 0x0927c0 with 0x0927C0 you will have 

Error: Error checking remote transaction, remote tr `gas` is different to test tr `gasLimit` (0x927c0 != 0x0927C0) (stMemExpandingEIP150Calls/CallAndCallcodeConsumeMoreGasThenTransactionHasWithMemExpandingCalls_d0g0v0_Berlin, fork: Berlin, block: 0)

Tested on this master(1ae26288eaac96e359e6f1c0bce441d6d64d6c33) with the t8ntool

Used Besu 1.4.6-SNAPSHOT