search

ethereum / sharding

Sharding manager contract, and related software and tests
480 stars 105 forks source link

Bump rlp, py-evm, vyper versions #93

Closed hwwhww closed 6 years ago

hwwhww commented 6 years ago

What was wrong?

  1. For #86, we actually have to bump many other dependency packages.
  2. Py-EVM CollationHeader is the latest spec, so now sharding repo should use CollationHeader to avoid duplicate.

How was it fixed?

  1. https://github.com/ethereum/vyper/pull/820 unlocked the py-evm version.
  2. Using latest eth-tester for our tests, which assigns specific py-evm version.
  3. Using latest rlp version.
  4. Using vyper with commit https://github.com/ethereum/vyper/commit/08ba8ed7c3c84d44edda85ff28c96bd1e2d867fe.
  5. Upgraded SMC code with latest Vyper spec.
  6. Using Py-EVM CollationHeader and helper functions. <-- Removed in #89
  7. Removed some useless tests.
  8. Using FORK_BYZANTIUM at eth-tester and the Vyper assert statements (using REVERT opcode) will refund gas now. So I removed all assert web3.eth.getTransactionReceipt(tx_hash)['gasUsed'] == default_gas from our tests.

close #86

Cute Animal Picture

leaves-animal-antlers-outdoors-deer-plants-cute-1866537

mhchia commented 6 years ago

Looks good to me!