search

ethereum / simplecasper

Casper PoC4 implementation
19 stars 10 forks source link

Add account management #6

Open karlfloersch opened 7 years ago

karlfloersch commented 7 years ago

We need some sort of account management. The flow for using the daemon accounts would be something like:

  1. Start your daemon for the first time, it generates or imports a key & encrypts it with a password
  2. You send some amount of ETH to the address it generated or imported
  3. You submit your deposit (login) and start validating

The account management is quite common behavior, and code already exists for account management. For instance, account.py in pyethapp. I don't want to reinvent the wheel, or simply copy and paste the code. I wish that there was a small library we could use for this. We can also import Account from pyethapp directly but I'm hesitant because it doesn't support state_revamp

@janx what do you suggest we do?

karlfloersch commented 7 years ago

I went with the dummy option of a massive copy/paste in this PR: https://github.com/ethereum/simplecasper/pull/7

Would love feedback on whether makes sense to pull the Account service into it's own library, or if we should do something else