Bump node versions in CI

ethereum / solc-js

Javascript bindings for the Solidity compiler

https://soliditylang.org

MIT License

1.45k stars 469 forks source link

Bump node versions in CI #716

Closed cameel closed 9 months ago

cameel commented 10 months ago

This bumps all minor versions to latest, and also adds a new run on node:current (which is node 21).

It also bumps node version in Hardhat jobs that were not on current only because at the time of node 17 Hardhat did not work with it.

Truffle does not work with node 21, but is fine with node 20, which is the current lts.

cameel commented 10 months ago

BTW, I see we still have a branch called bump-truffle-sample-project-to-node-18, that was apparently created during 0.8.22 release. @nikola-matic I assume it's safe to delete it now?

cameel commented 10 months ago

When we merge this, we should make node-current job mandatory.

I already made slight changes to required jobs:

coverage/coveralls for some reason disappeared but there's coverage/coveralls (push) now. This was preventing PRs from passing all of CI. Not sure what happened, but I'm guessing it's just a rename on their side so I changed the requirement to the latter.
I made the node 10 and Truffle jobs optional.

cameel commented 9 months ago

Maybe we could have a docker image parameter, like we have in the solidity repo

Not sure it's much of an improvement. We use specific versions only once now and the rest is cimg/node:current, which is already almost like a variable.

In the more repo it makes more sense because versions are long due to the embedded hash.

r0qs commented 9 months ago

Maybe we could have a docker image parameter, like we have in the solidity repo

Not sure it's much of an improvement. We use specific versions only once now and the rest is cimg/node:current, which is already almost like a variable.

In the more repo it makes more sense because versions are long due to the embedded hash.

Fair enough. Looks good to me then. And I suspect the hardhat test will fail because of similar problem here: https://github.com/ethereum/solidity/pull/14704. But we can fix that in https://github.com/ethereum/solc-js/pull/717.