search

ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
22.67k stars 5.62k forks source link

Fix modifier order in a style guide example #15082

Closed fearlesschenc closed 1 month ago

fearlesschenc commented 1 month ago

According to the modifier order for a function, custom modifier should placed behind of Mutability

github-actions[bot] commented 1 month ago

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

fearlesschenc commented 1 month ago

@mehtavishwa30

nikola-matic commented 1 month ago

Ah, I'm sorry, I already merged the PR that fixes this, which (https://github.com/ethereum/solidity/pull/15159) was actually a duplicate of yours.

fearlesschenc commented 1 month ago

Never mind, good to see the issue fixed