ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
23.13k stars 5.74k forks source link

Remove redundant prerequisite steps from the default optimizer sequence #15092

Open cameel opened 4 months ago

cameel commented 4 months ago

Since gho steps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.

For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.

If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.

cameel commented 4 months ago

Rebased on top of the new sequence.

cameel commented 4 months ago

No, we don't really document the default sequence.

We need a changelog entry though.

github-actions[bot] commented 4 months ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 3 months ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 2 months ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 2 months ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 1 month ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 1 month ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 2 weeks ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.

github-actions[bot] commented 11 hours ago

This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days unless the stale label is removed.