ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
22.64k stars 5.61k forks source link

Remove overly specific handlers for unexpected exceptions #15186

Closed cameel closed 1 week ago

cameel commented 3 weeks ago

In some places we have handlers for some exceptions that are unexpected and can reach those handlers only as a result of a bug. This is unnecessary and just complicates error handling. We should be explicitly handling expected exceptions and let everything else bubble up as far as possible and deal with it in the most generic handler possible.

cameel commented 2 weeks ago

I found some more unnecessary handlers in other places. Their removal is based on the same principle so I thought I'd add them ere instead of creating a new PR. Please take another look at it.

cameel commented 1 week ago

Thanks!