search

ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
22.64k stars 5.61k forks source link

Shared To Raw Pointers In Sorts.(cpp/h). #15193

Closed ToTheMax24 closed 2 weeks ago

ToTheMax24 commented 2 weeks ago

Made some small tweaks to the pointers in the Sorts.h and Sorts.cpp files to use raw pointers to reduce overhead. Would take some work elsewhere to fully implement, but this can be used as a starting point.

github-actions[bot] commented 2 weeks ago

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

nikola-matic commented 2 weeks ago

Hi @ToTheMax24. This isn't really as much of an improvement as you think it is - whilst using shared pointers here is an overhead, it is comparatively a tiny one, and one that wouldn't really make any perceptible difference in the performance of the compiler, especially seeing as this is only used in the SMT checker component. For that reason I'll be closing this PR (especially since the builds are failing, indicating that this would require more work on your part).