search

ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
22.64k stars 5.61k forks source link

Use submodules for some dependencies. #15195

Open aarlt opened 2 weeks ago

r0qs commented 2 weeks ago

We also need to update the build scripts, like build.sh. But I'm wondering why not just add the git submodule update --init in the CI build script and consequently all CI steps that build the code would already setup the submodules in the beginning of the build process.

r0qs commented 2 weeks ago

Actually, maybe even better, I think we could do all in cmake using execute_process, something like:

find_package(Git)
if(Git_FOUND)
    execute_process(COMMAND git submodule update --init ...)
    ... 
endif()

And also add the error message as suggested by @clonker if the submodules are not initialized correctly.

ekpyron commented 5 days ago

At least scripts/release_ppa.sh will also need adjustment - although we can do that separately, we'll have to confirm that that works with a prerelease PPA build - but we shouldn't forget in any case. Might be worthwhile to check if any other release build mechanisms also need adjustments, resp. to confirm that they work (like docker builds and such)