search

ethereum / solidity

Solidity, the Smart Contract Programming Language
https://soliditylang.org
GNU General Public License v3.0
23.11k stars 5.73k forks source link

Docs: Specify `blobhash()` behaviour when blob does not exist #15210

Closed ToonVanHove closed 1 month ago

ToonVanHove commented 3 months ago

Add description of blobhash() behaviour when the given blob does not exist. This is currently not specified.

github-actions[bot] commented 3 months ago

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

r0qs commented 3 months ago

Thanks @ToonVanHove, I'm already approving, but please remove the trailing whitespace as reported here: https://app.circleci.com/pipelines/github/ethereum/solidity/34603/workflows/0f99fcfa-1229-432c-9a19-d59a9ac4b4bb/jobs/1568548

r0qs commented 3 months ago

Please, also rebase and squash the commits ;)

ToonVanHove commented 3 months ago

Sorry about that, should be fixed!

ToonVanHove commented 3 months ago

I've added it to both the opcode table and the cheatsheet. Let me know if you'd like any further changes!