search

ethereum / sourcify

Decentralized Solidity contract source code verification service
https://sourcify.dev
MIT License
769 stars 378 forks source link

Use Node.js v22 #1446

Closed manuelwedler closed 2 months ago

manuelwedler commented 2 months ago

Closes #1428

manuelwedler commented 2 months ago
  1. That's because I upgraded prettier. It seems they changed the rule from v2 to v3. If you like to have no trailing comma, I can add the related rule. I personally prefer trailing commas, because it makes it a bit easier to move lines around.
  2. I already checked AWS. We already use Node v20 there, and that's also the highest version supported on Lambda at the moment.
kuzdogan commented 2 months ago

Ok I've moved prettier to root level and it seems to be resolved with that. My VSCode Prettier extension was resolving to a v2 Prettier. It makes more sense to have a single version in the root instead of individual versions in each module.

One thing I noticed is we still use node v18 in the monitor (check monitor/.nvmrc) Is that intentional?

manuelwedler commented 2 months ago

No, that wasn't intentional. We can remove the monitor/.nvmrc there, since we use the same version in the whole project now.

manuelwedler commented 2 months ago

I added some scripts to run prettier and eslint on all packages of the monorepo. That way prettier formatting is also checked in the CI.