Closed VargaElod23 closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The changes introduce configuration settings for the Taraxa Mainnet and Testnet into the sourcify-chains-default.json
file. Additionally, corresponding tests for verifying contracts on these networks were added to the chains/chain-tests.spec.ts
file. These updates enable support and interaction with the Taraxa blockchain networks within the service.
Files | Change Summary |
---|---|
services/server/src/sourcify-chains-default.json |
Added configuration details for Taraxa Mainnet and Testnet, including their names, support status, RPC endpoints, and contract creation transaction API. |
services/server/test/chains/chain-tests.spec.ts |
Added tests for verifying contracts on Taraxa Mainnet and Testnet. |
In lands of code both near and far,
Where nodes and chains a'dance,
Taraxa now joins the spar,
In both mainnet and testnet's chance.
With endpoints set and tests anew,
In blockchain light, our service grew.
✨🐰💻
[!TIP]
Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Hey there! Thanks for the PR. We were experimenting with Coderabbit lately, but it should actually not be running on the chain adding PRs. Please ignore these suggestions and remove your last commit. It is not necessary to have the chainId field there.
Could you please also remove the rpc fields? We are already getting these from the chains.json
All done @manuelwedler
Please also remove the chainId fields
Oh, I thought I amended that, sorry, it slipped out somehow. Done now @manuelwedler
Is the given contract for the Taraxa Testnet (842) changed? Now the bytecode of 0x98edEa58C0500287B973348ec315f3d26D0e189A
is returning a different result and the test is failing. I can see this PR is from Jul 2 but the explorer shows this contract was deployed on Jul 26: https://testnet.explorer.taraxa.io/address/0x98edea58c0500287b973348ec315f3d26d0e189a Is this testnet being reset?
Please fix the contract otherwise we'll have to remove support for the testnet
Add New Chain
Thanks for your pull request to add a new support in Sourcify.
If you haven't done so, please follow the instructions on how to request chain support in docs.
Please check the following items before submitting your pull request for a speedy review.
Checklist
add-chain-<chainId>
.chains.json
file directly.sourcify-chains.json
filesupported: true
.rpc
field but the one in chains.json is used (if not, please explain why).test-new-chain
test in Circle CI is passing.Summary by CodeRabbit
New Features
Tests