search

ethereum / sourcify

Decentralized Solidity contract source code verification service
https://sourcify.dev
MIT License
775 stars 384 forks source link

Remix plugin: Test proxy verification manually #1533

Closed manuelwedler closed 4 days ago

manuelwedler commented 1 month ago

I haven't fully tested the proxy verification. We should deploy some proxy contracts, and try verifying them to make sure all API calls are working correctly and the UI shows the correct state of the verification.

Important here is that the implementation contract needs to be verified before the API call for proxy contract verification can be made. Especially, we should try with only Etherscan enabled, as enabling other verifiers can add some delays to the API calls.

manuelwedler commented 4 days ago

Tested it and made a small fix for awaiting the verification of the implementation before verifying the proxy: https://github.com/sourcifyeth/remix-project/commit/7b8673674757461143e2a508a1455e1fafbdd5cf