ethereum / ssv

The repository has moved to https://github.com/bloxapp/ssv
https://github.com/bloxapp/ssv
24 stars 12 forks source link

Own node signiture verification error #40

Closed CarlBeek closed 3 years ago

CarlBeek commented 3 years ago

In the genesis attestation, I receive error messages about failing to verify a node n's signature where n is my node's number. (I know @adiasg had the same bug with his node.) Despite two of us (who are peers) "failing" to verify a signature, the attestation went through fine.

...

{"level":"WARN","time":"2021-04-20T20:04:24.948060Z","caller":"ibft/pipeline.go:24","message":"undefined message type","app":"SSV-CLI","node_id":n,"eth2Network":"pyrmont","discovery-type":"discv5","val":"validation","beacon-addr":"eth2-4000-prysm-ext.stage.bloxinfra.com:80","validator":"0xaa96176258df...","start_time":"2021-04-20T20:04:19.000000Z","committee_index":27,"slot":1104021,"role":"ATTESTER","node_id":3,"msg":"message:<lambda:\"1104021_ATTESTER\" > signature:\"\\242Z\\362\\266\\213\\036!\\360vP\\343\\334dA^\\003C\\357\\270\\343p0'\\005\\252\\366V\\267\\247\\330[\\265n\\345\\331\\372*\\370\\220\\351\\350n\\333\\351\\377\\316 ~\\r\\366f\\347`\\334\\317\\006\\377\\201\\251\\205z\\305\\242\\315\\374!MA\\001e\\346bs\\000\\334U\\213\\367C`L\\\"\\344+\\277\\362!\\363\\001\\177C\\224\\312\\021\\245\\304\" signer_ids:1 "}

...

{"level":"ERROR","time":"2021-04-20T20:04:26.120147Z","caller":"node/duty_execution.go:63","message":"received invalid signature","app":"SSV-CLI","node_id":n,"eth2Network":"pyrmont","discovery-type":"discv5","val":"validation","beacon-addr":"eth2-4000-prysm-ext.stage.bloxinfra.com:80","validator":"0xaa96176258df...","start_time":"2021-04-20T20:04:19.000000Z","committee_index":27,"slot":1104021,"role":"ATTESTER","error":"could not verify signature from iBFT member 3","errorVerbose":"could not verify signature from iBFT member 3\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}

...

{"level":"ERROR","time":"2021-04-20T20:04:26.122283Z","caller":"node/duty_execution.go:63","message":"received invalid signature","app":"SSV-CLI","node_id":3,"eth2Network":"pyrmont","discovery-type":"discv5","val":"validation","beacon-addr":"eth2-4000-prysm-ext.stage.bloxinfra.com:80","validator":"0xaa96176258df...","start_time":"2021-04-20T20:04:19.000000Z","committee_index":27,"slot":1104021,"role":"ATTESTER","error":"could not verify signature from iBFT member 3","errorVerbose":"could not verify signature from iBFT member 3\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}
CarlBeek commented 3 years ago

It is not limited to It appears it is not limited to genesis nor to my node. My logs report signature failures of several of my peers.

eg.

{"level":"ERROR","time":"2021-04-20T20:32:36.576382Z","caller":"node/duty_execution.go:63","message":"received invalid signature","app":"SSV-CLI","node_id":3,"eth2Network":"pyrmont","discovery-type":"discv5","val":"validation","beacon-addr":"eth2-4000-prysm-ext.stage.bloxinfra.com:80","validator":"0xaa96176258df...","start_time":"2021-04-20T20:32:31.000000Z","committee_index":2,"slot":1104162,"role":"ATTESTER","error":"could not verify signature from iBFT member 4","errorVerbose":"could not verify signature from iBFT member 4\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}
adiasg commented 3 years ago

Posting my logs for reference (I am node_id 4):

...
2021-04-20T20:06:37.285282Z WARN    ibft/pipeline.go:24 undefined message type  {"app": "Starts an instance of SSV node", "node_id": 4, "start_time": "2021-04-20T20:06:31.000000Z", "committee_index": 14, "slot": 1104032, "role": "ATTESTER", "node_id": 4, "msg": "message:<lambda:\"1104032_ATTESTER\" > signature:\"\\220r\\3649\\363R\\207\\276,\\377\\366\\007\\255x\\357\\304{%\\236oE8n\\332Z\\037\\347\\226+sd\\036\\314\\037\\026\\265svo\\226\\255\\215\\304\\272<\\306\\323\\023\\025q\\272]\\007\\320\\324\\242b \\341{&E4\\377[\\305\\020^V\\364\\200_\\222*\\243-\\306\\342Q\\t1\\223\\225\\265[\\2664\\032WRz\\023\\322\\335\\266\\313\" signer_ids:2 "}
...
2021-04-20T20:06:37.405898Z ERROR   node/duty_execution.go:63   received invalid signature  {"app": "Starts an instance of SSV node", "node_id": 4, "start_time": "2021-04-20T20:06:31.000000Z", "committee_index": 14, "slot": 1104032, "role": "ATTESTER", "error": "could not verify signature from iBFT member 4", "errorVerbose": "could not verify signature from iBFT member 4\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}
...
2021-04-20T20:14:36.514594Z ERROR   node/duty_execution.go:63   received invalid signature  {"app": "Starts an instance of SSV node", "node_id": 4, "start_time": "2021-04-20T20:14:31.000000Z", "committee_index": 0, "slot": 1104072, "role": "ATTESTER", "error": "could not verify signature from iBFT member 3", "errorVerbose": "could not verify signature from iBFT member 3\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}
...
2021-04-20T20:19:38.203048Z ERROR   node/duty_execution.go:63   received invalid signature  {"app": "Starts an instance of SSV node", "node_id": 4, "start_time": "2021-04-20T20:19:19.000000Z", "committee_index": 16, "slot": 1104096, "role": "ATTESTER", "error": "could not verify signature from iBFT member 3", "errorVerbose": "could not verify signature from iBFT member 3\ngithub.com/bloxapp/ssv/node.(*ssvNode).verifyPartialSignature\n\t/go/src/github.com/bloxapp/ssv/node/signature.go:35\ngithub.com/bloxapp/ssv/node.(*ssvNode).waitForSignatureCollection\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:62\ngithub.com/bloxapp/ssv/node.(*ssvNode).postConsensusDutyExecution\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:111\ngithub.com/bloxapp/ssv/node.(*ssvNode).executeDuty.func1\n\t/go/src/github.com/bloxapp/ssv/node/duty_execution.go:230\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}