search

ethereum / staking-deposit-cli

Secure key generation for deposits
Creative Commons Zero v1.0 Universal
537 stars 338 forks source link

Clarify which Python versions are supported #392

Open rootulp opened 10 months ago

rootulp commented 10 months ago

Context

https://github.com/ethereum/staking-deposit-cli/blob/fdab65d33a63632e1935e9a9235119a46e37c221/README.md?plain=1#L199-L205

Problem

The README states Python > 3.8 is supported but that's not the case. See https://github.com/ethereum/staking-deposit-cli/issues/363

Proposal

Until https://github.com/ethereum/staking-deposit-cli/issues/363 is resolved, can the README explicitly state the versions of Python that are supported

yorickdowne commented 2 months ago

Come on over, we have Python 3.11, 3.12 and even 3.13.0-rc.1 in our CI. But minimum 3.9, we dropped 3.8.

Recommend sticking to Holesky with our fork until we have the re-audit done. And, we can use all the help we can get in testing.

https://github.com/eth-educators/ethstaker-deposit-cli