ethereum / staking-launchpad

The deposit launchpad for staking on Ethereum 🦏
Creative Commons Zero v1.0 Universal
278 stars 198 forks source link

Broken OG image #373

Open samajammin opened 3 years ago

samajammin commented 3 years ago

Current open graph image is broken Image 2021-03-08 at 1 26 09 PM

Should be: https://launchpad.ethereum.org/static/media/eth2-leslie-rhino.243747b9.png

hwwhww commented 3 years ago

I tried with updated https://pyrmont.launchpad.ethereum.org/, it seems we still have problems with Twitter card: image

@samajammin any ideas?

samajammin commented 3 years ago

Hmmm ya I see that same issue.

It does appear to work fine w/ Facebook debugger: Image 2021-03-16 at 7 30 38 AM

Not sure why Twitter reports errors... it should fall back to Open Graph metadata 🤔 but we can add twitter-specific metadata just to be sure.

hwwhww commented 3 years ago

It seems that it still doesn't work with Twitter. 😭

image

samajammin commented 3 years ago

Hmmm so this is with https://github.com/ethereum/eth2.0-deposit/pull/381 deployed, ya?

hwwhww commented 3 years ago

@samajammin yes, that was after Pyrmont release on March 17th: https://github.com/ethereum/eth2.0-deposit/pull/382

samajammin commented 3 years ago

Ultimately I suspect this is an issue with the fact that the site is not server-side rendered. We need dynamic tags (so that every page doesn't have the same title tag / meta description) but in doing so, the tags are not in the static HTML. I suspect Twitter's crawlers don't run the the JavaScript on the site; they simply take the meta tags from the initial bundle.

Might require a more intensive fix than I hoped 😕 I was hoping Twitter's crawlers were smarter.

samajammin commented 3 years ago

More on this: