search

ethereum / staking-launchpad

The deposit launchpad for staking on Ethereum 🦏
Creative Commons Zero v1.0 Universal
268 stars 183 forks source link

metamask-ledger integration issue #549

Open hwwhww opened 1 year ago

hwwhww commented 1 year ago

Reported by @fredriksvantes (🙌). Quote his words:

Issue

My tests shows that metamask-ledger works fine on websites like app.uniswaporg, but not on the launchpad. i tested with two different OS and two different browsers on each OS, and the latest ledger firmware. it provides this error message: "Ledger: Condition of use not satisfied (denied by user?) (0x6985) after pressing confirm in metamask.

Possible root cause

Locally, i updated the web3, web3-utils, all @ethersproject and all @web3-react packages to their latest version, but it's still not working. my guess is something stopped working with the @web3-react/injected-connector, which can't be updated as it has been deprecated in favor of the "metamask" package: https://github.com/Uniswap/web3-react/tree/main/packages/metamask

Hi @wackerow, do you have bandwidth to help investigate how to switch our metamask package dependency?

I suppose it has to be fixed based on the node.js & web3 package upgrade fix (#543)

valefar-on-discord commented 1 week ago

I played around with this for a few hours and believe that updating the web-react package would likely fix the issue.

However, as mentioned by others, I too ran into dependency hell and was concerned about the blast radius of the change.

I had a brief discussion with Paul and we agreed the best path forward, given the state of this project, is to provide better error messaging to the user which I did #692

Ethstaker sees this issue pop up quite often and we answer in the same manner that the error message describes so we are confident that, though it isn't a perfect solution, it will provide clear direction to the user allowing them to resolve this issue on their own.