ethereum / staking-launchpad

The deposit launchpad for staking on Ethereum 🦏
Creative Commons Zero v1.0 Universal
278 stars 198 forks source link

Removing cli version checker #714

Open valefar-on-discord opened 1 month ago

valefar-on-discord commented 1 month ago

When generating a deposit with the staking-deposit-cli, the resulting deposit file will contain a cli version: deposit_cli_version. The launchpad currently verifies this value is above a certain threshold defined in the env file, 2.7.0.

There are two problems:

To get around these two issues, this PR removes the version check entirely.

As a side effect, compare-version is no longer a direct dependency as this was the only location where it it is used but it is still a dependency of husky

netlify[bot] commented 1 month ago

Deploy request for dapper-rolypoly-9814ad pending review.

Visit the deploys page to approve it

Name Link
Latest commit 40612f9ba97eababdbaa60d2ba1e94f706d289c4
valefar-on-discord commented 1 month ago

@wackerow Here is the PR as promised.