ethereum / testeth

One consensus test generator
GNU General Public License v3.0
11 stars 12 forks source link

Can we move testeth back into cpp-ethereum? #23

Open pirapira opened 6 years ago

pirapira commented 6 years ago

Discussion so far https://github.com/ethereum/testeth/issues/9#issuecomment-374972651 https://github.com/ethereum/testeth/issues/9#issuecomment-375229407 https://github.com/ethereum/testeth/issues/9#issuecomment-375236005 https://github.com/ethereum/testeth/issues/9#issuecomment-375238572 https://github.com/ethereum/testeth/issues/9#issuecomment-375239476 https://github.com/ethereum/testeth/issues/9#issuecomment-375264388

pirapira commented 6 years ago

I think https://github.com/ethereum/tests/issues/436 is a blocker. If we move the process back to cpp-ethereum repository now, whenever tests are updated, a new PR (like this) would appear in cpp-ethereum, for testing the test cases.

winsvega commented 6 years ago

I guess we will have to move it back or support the testeth in cpp. Because cpp tests via RPC are too slow and wont run in travis build in time untill we optimize cpp client to do be able to do that

gumb0 commented 6 years ago

We have testeth copy in cpp-ethereum which we use to run the tests now. Given that test format is not supposed to change much we can continue to use it even in retesteth era, right?

winsvega commented 6 years ago

I guess yes. but there will be some changes. And it wont be capable of generating new tests.

gumb0 commented 6 years ago

Not generating the tests is fine. Changes to the test format are not fine, but we can decide later what's easier - supporting the changes or making RPC test calls faster

winsvega commented 6 years ago

The blockchain test format stays.