search

ethereum / testeth

One consensus test generator
GNU General Public License v3.0
11 stars 12 forks source link

Deal with YAML -1 translated into "-1" #31

Closed pirapira closed 6 years ago

pirapira commented 6 years ago

When the filler file is YAML, integer -1 in the YAML file is translated into "-1" string, and that messes with the state test filling mechanism. This PR adds an error message that suggests a better way to write -1 in YAML.

@pirapira needs to create a github issue to fix the YAML to JSON translation properly.

codecov-io commented 6 years ago

Codecov Report

Merging #31 into develop will decrease coverage by 0.4%. The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
- Coverage    71.93%   71.53%   -0.41%     
===========================================
  Files           83       83              
  Lines        10891    10095     -796     
  Branches      1152     1034     -118     
===========================================
- Hits          7834     7221     -613     
+ Misses        2657     2421     -236     
- Partials       400      453      +53
pirapira commented 6 years ago

The solution seems to be changing the YAML file like this: https://github.com/ethereum/tests/issues/385#issue-282281305

So, this PR should not fix the data on the fly, but emit an error message suggesting the above change.