search

ethereum / tests

Common tests for all Ethereum implementations
MIT License
558 stars 319 forks source link

Unify zero/non-existent storage slots #1330

Closed chfast closed 8 months ago

chfast commented 10 months ago

Storage slots of zero values are interpreter as non-existent / deleted and these are not included in the Merke-Patricia Trie. It is incorrect for the tests to contain a pre-state with explicit zero storage values.

winsvega commented 9 months ago

Is there a difference then? Zero slots can be interpreted as non existent. Or is it causing wrong post state results?

chfast commented 9 months ago

It requires the special handling of the test state because zero values are never in the trie. E.g. you need to specifically filter zeros when loading JSON.

winsvega commented 8 months ago

https://github.com/ethereum/tests/pull/1347

winsvega commented 8 months ago

a few in pyspecs to fix as well

winsvega commented 8 months ago

done