search

ethereum / tests

Common tests for all Ethereum implementations
MIT License
560 stars 319 forks source link

bug: `uint` should not be used for method signature encoding? #1369

Open lispc opened 6 months ago

lispc commented 6 months ago

https://github.com/ethereum/tests/blob/1c23e3c27ac53b794de0844d2d5e19cd2495b9d8/src/GeneralStateTestsFiller/Cancun/stEIP1153-transientStorage/15_tstoreCannotBeDosdFiller.yml#L27C16-L27C44

0x883264e8 is the keccak of doCall(uint). While the solidity spec claimed 

uint, int: synonyms for uint256, int256 respectively. 
For computing the function selector, uint256 and int256 have to be used.

So is this correct? Should use doCall(uint256) for signature?

winsvega commented 6 months ago

hm, but it seems to still work when calling solc generated contracts