search

ethereum / tests

Common tests for all Ethereum implementations
MIT License
553 stars 315 forks source link

Remove RETURNCONTRACT validation tests #1391

Closed gumb0 closed 2 months ago

gumb0 commented 2 months ago

These tests are migrated to EEST in https://github.com/ethereum/execution-spec-tests/pull/647

(To keep them here we would need to support "initcode" flag in EOF validation tests, and it seems not worth the effort to do it at this point, it's easier to just remove).

winsvega commented 2 months ago

we have introduced coverage checkup. if you add converted json files to ethereum-converte-tests file in pyspecs. it will measure the coverage of eof tests on pyspec version vs this .json you are about to remove, please try it out.

chfast commented 2 months ago

we have introduced coverage checkup. if you add converted json files to ethereum-converte-tests file in pyspecs. it will measure the coverage of eof tests on pyspec version vs this .json you are about to remove, please try it out.

This doesn't work: https://github.com/ethereum/execution-spec-tests/actions/runs/9715118299

winsvega commented 2 months ago

again? https://github.com/ethereum/execution-spec-tests/pull/657

chfast commented 2 months ago

again? ethereum/execution-spec-tests#657

This is not merged? :shrug:

chfast commented 2 months ago

@winsvega Can you make an example migration PR? It looks you made a tool for migration but it is untested.

winsvega commented 2 months ago

You mean the coverage? Its in pyspec repo closed PRs titled TEST https://github.com/ethereum/execution-spec-tests/pull/656

winsvega commented 2 months ago

again? ethereum/execution-spec-tests#657

This is not merged? :shrug:

I can't merge without review.

You can just add these changes to your pr.

chfast commented 2 months ago

You can just add these changes to your pr.

I did, but it seems the evmone used is out of date. I'm not sure how to read this report.

winsvega commented 2 months ago

the coverage check didn't complete, but its eof tests so let it go. 

Error: Contents of /home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json is empty. Trying to parse empty file. (forgot --filltests?) (EOFTests/efValidation/EOF1_returncontract_valid_Copier, step: CheckFiller)
Error: 
Error when parsing file (/home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json) Contents of /home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json is empty. Trying to parse empty file. (forgot --filltests?)

the source and the generated test files must be removed.

gumb0 commented 2 months ago

the source and the generated test files must be removed.

fixed