search

ethereum / tests

Common tests for all Ethereum implementations
MIT License
553 stars 315 forks source link

Discrepancy in chainId for BlockchainTests in EIP-6780 Selfdestruct Tests #1394

Open anvacaru opened 1 month ago

anvacaru commented 1 month ago

I noticed that some of the BlockchainTests tests, mainly the ones under cancun/eip6780_selfdestruct, are executed on a state that has the chainId set to 0 instead of 1. Is there a reason they have a different chainId than the rest of the test suite?

Alternatively, would you consider storing the chainId under the _info field of the JSON test? Or add it as a new field on the same level as sealEngine and network? I know it is already part of the transaction field, but I consider that a post-state check, similar to sender.

winsvega commented 2 weeks ago

this are generated by pyspecs. .py fillers.