Closed holgerd77 closed 2 months ago
Ah, just seeing, this (wrong uncle block number) is the case for the following blocks as well.
Hm? Block5 includes version of block4 as uncle.
Looks correct to me, uncle can be a sibling to one of 6 of this block's ancestors (block.number - 6 <= uncle.number <= block.number - 1
)
Thanks, yes, we have discussed/researched this internally and came to the same conclusion! 🙂 Will close.
In the
londonUncles.json
transition tests there is a wrong uncles block number (4) for block number 5, see https://github.com/ethereum/tests/blob/fd26aad70e24f042fcd135b2f0338b1c6bf1a324/BlockchainTests/TransitionTests/bcBerlinToLondon/londonUncles.json#L158 .Is this intended for some reason (I could imagine that uncle header number is just not checked by specification, unlikely though?). Or is this a bug?