ethereum / tests

Common tests for all Ethereum implementations
MIT License
563 stars 320 forks source link

Misleading comments in test filler #1407

Open xrchz opened 1 month ago

xrchz commented 1 month ago

https://github.com/ethereum/tests/blob/9201075490807f58811078e9bb5ec895b4ac01a5/src/GeneralStateTestsFiller/VMTests/vmTests/calldatacopyFiller.yml#L171

The comments claim a 0x10 byte long value is going into memory, but then the value is 0x11 bytes. I think this may be related to another misleading comment earlier that says an mload should produce 0 when it in fact produces 0x12.

winsvega commented 3 weeks ago

feel free to correct