feat(beacon-network): add content validation

[ogenev]

What was wrong?

We don't validate the beacon content type before storing and gossiping.

How was it fixed?

• Add validations for the beacon content types.
• Extract a test_utils module for common usage in tests.

To-Do

• [ ] Clean up commit history and use conventional commits.

[pipermerriam]

Reading through the validation code here, I wanted to ask what the status of our hive tests is for validating these objects. It seems like with as many validation checks as there are it would be easy for a client to miss or incorrectly implement the validation logic. If we don't have comprehensive tests vectors in place for both valid and invalid payloads, that seems like a place where effort should go. At minimum, getting issues written in the specs repo that detail the tests that need to be written.

[KolbyML]

Reading through the validation code here, I wanted to ask what the status of our hive tests is for validating these objects. It seems like with as many validation checks as there are it would be easy for a client to miss or incorrectly implement the validation logic. If we don't have comprehensive tests vectors in place for both valid and invalid payloads, that seems like a place where effort should go. At minimum, getting issues written in the specs repo that detail the tests that need to be written.

Currently there is no negatives, and we don't really test for positives either

[ogenev]

Reading through the validation code here, I wanted to ask what the status of our hive tests is for validating these objects. It seems like with as many validation checks as there are it would be easy for a client to miss or incorrectly implement the validation logic. If we don't have comprehensive tests vectors in place for both valid and invalid payloads, that seems like a place where effort should go. At minimum, getting issues written in the specs repo that detail the tests that need to be written.

Yeah, we will work on adding more tests for testing content validations for history and beacon. We are currently trying to fix the failing beacon hive tests for Trin.