ethereum / trin

An Ethereum portal client: a json-rpc server with nearly instant sync, and low CPU & storage usage
382 stars 112 forks source link

Switch Cargo.toml in packages to use workspace dependencies #1407

Closed carver closed 2 months ago

carver commented 2 months ago

What was wrong?

Fix #845

How was it fixed?

My process:

There are several dependencies that are only used in a single package. I can see arguments for moving them to the workspace for tracking too. For example, if we don't move the dependencies, then it will be easy to accidentally create duplicates again in the future. But I landed on leaving them in place, because:

  1. It highlights that removing a singular dependency from a package will completely remove it from the whole workspace
  2. It feels a tiny bit burdensome to add every future dependency to the workspace when it's only in use in one place. So I wasn't ready to pick that as the new norm

But I'm open to persuasive arguments :)

To-Do

carver commented 2 months ago

Since Cargo.lock wasn't updated, does that mean that there was no dependency that was used with different version?

Yeah, I think because of the regular updates, like this one, most of the locked dependencies were further ahead of any of the Cargo.toml specs anyway.

Somewhat related, should we create issue(s) for

Sure, I'll take a stab at writing some up 👍🏻