ethereum / trin

An Ethereum portal client: a json-rpc server with nearly instant sync, and low CPU & storage usage
382 stars 112 forks source link

perf: speed up tests by disabling UPnP #1425

Closed carver closed 2 months ago

carver commented 2 months ago

Trying and failing to configure UPnP causes a 10second delay during each test that tries it.

What was wrong?

Some tests were slow locally (and presumably in CI).

How was it fixed?

Disable upnp during the test.

Comparing this CI run against a recent test run shows a test speedup of 2 minutes and 21 seconds -- 8:42 vs 6:21.

To-Do