search

ethereum / trin

An Ethereum portal client: a json-rpc server with nearly instant sync, and low CPU & storage usage
382 stars 112 forks source link

chore: remove unix only + experimental messaging from readme #1426

Closed KolbyML closed 2 months ago

KolbyML commented 2 months ago

What was wrong?

Removing the 2 issues from the readme.

Programs change overtime for example sigp/discv5 and ethereum/go-ethereum change over time but don't have this kind of messaging in the readme.

If we verbally say we are ready for other's to take us seriously, I think messaging and this PR is the first step.

Same goes for window's support

ogenev commented 2 months ago

I don't feel that removing the unix only note from the readme is the first step for fully supporting Windows. I think we need to first identify what are the current bottlenecks (if any) for fully supporting the platform.

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

KolbyML commented 2 months ago

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

Can you link a source maybe I have a misunderstanding how cargo check works?

KolbyML commented 2 months ago

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

Can you link a source maybe I have a misunderstanding how cargo check works?

To my understanding https://doc.rust-lang.org/cargo/commands/cargo-check.html cargo check does everything but code generation, which to my knowledge should check all compilations error's cargo build would. So it is like cargo build but faster and hence good for CI

ogenev commented 2 months ago

Can you link a source maybe I have a misunderstanding how cargo check works?

https://rust-lang.github.io/rfcs/3477-cargo-check-lang-policy.html#decision

https://stackoverflow.com/a/69140084

KolbyML commented 2 months ago

Can you link a source maybe I have a misunderstanding how cargo check works?

https://rust-lang.github.io/rfcs/3477-cargo-check-lang-policy.html#decision

https://stackoverflow.com/a/69140084

Ah ok in that case maybe we should just stop using cargo check all together. Thank you for informing me I wasn't aware of that