refactor: change RawContentKey to alloy_primites::Bytes

ethereum / trin

An Ethereum portal client: a json-rpc server with nearly instant sync, and low CPU & storage usage

365 stars 113 forks source link

refactor: change RawContentKey to alloy_primites::Bytes #1431

Closed etherhood closed 2 weeks ago

etherhood commented 3 weeks ago

What was wrong?

Vec<u8> was being used to represent Raw Content Key.

See #1404 for details

How was it #fixed?

Replaced it with alloy_primites::Bytes

To-Do

[ ] Clean up commit history and use conventional commits.

morph-dev commented 3 weeks ago

Also, see https://www.conventionalcommits.org/en/v1.0.0/ for failing check.

etherhood commented 3 weeks ago

Implemented RawContentKey in OverlayContentKey and in downstream traits as well

morph-dev commented 2 weeks ago

You can ignore failing commitlint check, as I will squash and merge changes anyway.

But for the future, problem is the commit message: "fix: CI fixes and resolved conflicts with master", because it starts with capital letter (maybe something that we should change in our configuration).

etherhood commented 2 weeks ago

Fixed the commit message and remove From impl for StateContentKey