search

ethereum / trin

An Ethereum portal client: a json-rpc server with nearly instant sync, and low CPU & storage usage
365 stars 113 forks source link

Websocket port should be configurable via cli arguments #764

Open njgheorghita opened 1 year ago

njgheorghita commented 1 year ago

https://github.com/ethereum/trin/pull/757#discussion_r1219642958

ogenev commented 1 year ago

HTTP and WS must run on a separate port. Current defaults are 8545 for HTTP and 8546 for WS.

njgheorghita commented 1 year ago

Following up ^ - it appears as though all of this logic should also be removed... https://github.com/ethereum/trin/blob/master/rpc/src/rpc_server.rs#L385-L425

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 42 days with no activity.