search

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.
http://web3py.readthedocs.io
MIT License
5k stars 1.7k forks source link

Replace `ipc_path` variable with `endpoint_uri` #3264

Closed ehdgks0627 closed 6 months ago

ehdgks0627 commented 7 months ago

What was wrong?

The AsyncIPCProvider class was using ipc_path instead of endpoint_uri from its super class, PersistentConnectionProvider.

How was it fixed?

Remove the usage of ipc_path and replaced it with endpoint_uri in the PersistentConnectionProvider class.

fselmo commented 7 months ago

I don't think this is ideal as endpoint_uri implies there exists an endpoint URI. I think we should remove the typing from PersistentConnectionProvider, L33, and let WebSocketProvider define and use endpoint_uri and let AsyncIPCProvider define and use ipc_path.

Does that make sense?