Some lint errors have appeared in web3._utils.abi.py. Possibly related to recent eth-abi releases, but same lint errors after installing older eth-abi versions. :shrug:
How was it fixed?
Three main mypy complaints:
The def is_dynamic attempts to overwrite the class attribute is_dynamic with the @property function is_dynamic. I changed it to be a regular class attribute, as is standard across eth-abi
validate_value's signature was being altered by the combomethod decorator so it didn't match the parent ABC function sig. I determined that because the function uses subencoder, which only exists if the class has been instantiated, it cannot be a classmethod or a combomethod. Removing the decorator removes the mypy error. Removed the return as well - the function is supposed to either not return or throw an error.
from_type_str returns an instance of an encoder class, with the cls(...) calling the __init__ function of the parent class. But (I think) because the @parse_type_str decorator turns from_type_str into a classmethod, mypy thinks cls(...) is calling the __call__ method, so the args are wrong (as is the return type of bytes, so I updated that here too.)
I'll make a note to come back and see if @parse_type_str can be removed, but for now I think ignoring the last error is the best (most timely) option.
What was wrong?
Some lint errors have appeared in
web3._utils.abi.py. Possibly related to recenteth-abireleases, but same lint errors after installing oldereth-abiversions. :shrug:How was it fixed?
Three main mypy complaints:
def is_dynamicattempts to overwrite the class attributeis_dynamicwith the@propertyfunctionis_dynamic. I changed it to be a regular class attribute, as is standard acrosseth-abivalidate_value's signature was being altered by thecombomethoddecorator so it didn't match the parent ABC function sig. I determined that because the function usessubencoder, which only exists if the class has been instantiated, it cannot be aclassmethodor acombomethod. Removing the decorator removes the mypy error. Removed thereturnas well - the function is supposed to either not return or throw an error.from_type_strreturns an instance of an encoder class, with thecls(...)calling the__init__function of the parent class. But (I think) because the@parse_type_strdecorator turnsfrom_type_strinto aclassmethod, mypy thinkscls(...)is calling the__call__method, so the args are wrong (as is the return type ofbytes, so I updated that here too.)I'll make a note to come back and see if
@parse_type_strcan be removed, but for now I think ignoring the last error is the best (most timely) option.Todo:
Cute Animal Picture