[v6] EventABI Topics with Indexed Arguments

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

5k stars 1.7k forks source link

[v6] EventABI Topics with Indexed Arguments #3288

Closed reedsa closed 7 months ago

reedsa commented 7 months ago

What was wrong?

Closes #3286

How was it fixed?

When event ABI topics are converted to a "log topic" in event_abi_to_log_topic, it returns a value in bytes. Comparing this with the topic value often fails when the value is just a hex string and not HexBytes. So this is to ensure everything is converted to hex before comparing event signatures from logs with that from the event ABI.

Todo:

[x] Add entry to the release notes

Cute Animal Picture

DefiDebauchery commented 7 months ago

These changes work on my end, as well. Thanks!