Since we defined endpoint_uri at the PersistentConnectionProvider level, we used it in the manager.py since it wouldn't raise any attribute errors. Rather than rename the ipc_path in AsyncIPCProvider, I think it makes sense to have this separation of paths but be able to retrieve either path from the base class as well since we may want to implement logic for the base class (as is the case in manager.py).
How was it fixed?
Implement endpoint_uri_or_ipc_path property in the base class to be able to return the proper path depending on the type of persistent connection provider.
What was wrong?
Since we defined
endpoint_uriat thePersistentConnectionProviderlevel, we used it in themanager.pysince it wouldn't raise any attribute errors. Rather than rename theipc_pathinAsyncIPCProvider, I think it makes sense to have this separation of paths but be able to retrieve either path from the base class as well since we may want to implement logic for the base class (as is the case inmanager.py).How was it fixed?
endpoint_uri_or_ipc_pathproperty in the base class to be able to return the proper path depending on the type of persistent connection provider.Todo:
Cute Animal Picture