feat(geth): Add debug_traceTransaction RPC method to Geth module

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

4.91k stars 1.68k forks source link

feat(geth): Add debug_traceTransaction RPC method to Geth module #3334

Open wangereth opened 3 months ago

wangereth commented 3 months ago

What was wrong?

Related to Issue #3330

How was it fixed?

Add debug module in geth.
Implement debug_traceTransaction RPC Method first

Todo:

[ ] Clean up commit history
[ ] Add or update documentation related to these changes
[ ] Add entry to the release notes

Cute Animal Picture

kclowes commented 3 months ago

Thanks! This looks like the right approach. Let me know when this is ready for review!

wangereth commented 3 months ago

Thanks! This looks like the right approach. Let me know when this is ready for review!

Hello, I implemented debug_traceTransaction with callTracer config, and tested it myself. Maybe you can help me review it now to check if is it ok.

kclowes commented 3 months ago

This looks good so far! Do you mind adding some tests? We'll probably want to add a new file to web3/_utils/module_testing, and then the new class will need to be added to the integration tests in tests/integration/go_ethereum/test_go_ethereum_*.py. Let me know if you need an example or if you don't have time and/or don't want to and I can take it from here. Thanks!

wangereth commented 3 months ago

Sure, I will try to add test, I will ask you for help if there is any questions.

wangereth commented 3 months ago

@kclowes I have add some tests, please help review if it's ok.

wangereth commented 2 months ago

hi, @kclowes , I have no idea why the py312-core check failed, please have a look.

I don't think I have changed code related to the failed test.

wangereth commented 2 months ago

pytest tests/core/caching-utils/test_generate_cache_key.py --hypothesis-seed=243990134122841475368898544757628869001 will fail, but with any other seed it will success.

wangereth commented 2 months ago

kclowes commented 2 months ago

We're failing on main too, so it's not anything in here. I'm planning to take a look at this PR this week. Thanks for the patience!